Lint manual #25312
Merged
Lint manual #25312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
I guess the CodeQL warnings are existing ones which just pop up because you are modifying the respective lines of code, right? |
|
Yes, I think so. |
Mugen87
approved these changes
Jan 22, 2023
|
BTW: Do you know why I can't test your branch via githack? It works with other PRs without issues. So this link should work: https://raw.githack.com/LeviPesin/three.js/lint-manual/manual/index.html |
I think I made an error while cloning the repository some time ago, so it is actually named LeviPesin/three.js-1, not LeviPesin/three.js... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #25251
Description
Fix manual so that it adheres to three.js code lint standards.