Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Display percentage of pixels failed #25305

Merged
merged 1 commit into from
Jan 19, 2023
Merged

E2E: Display percentage of pixels failed #25305

merged 1 commit into from
Jan 19, 2023

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #25304

Description

In #25304 one of the screenshot failures displayed the following:

Diff wrong in 0.406 of pixels in file

It was unclear whether this mean 0.406% of pixels failed or 40.6% of pixels failed. I've changed the logs to be more specific about the ratio.

@mrdoob mrdoob added this to the r149 milestone Jan 19, 2023
@mrdoob mrdoob merged commit 44e95b9 into dev Jan 19, 2023
@mrdoob mrdoob deleted the display-perc-failed branch January 19, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants