PMREMGenerator: Fix replacing render targets with different heights #25301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #23322
Description
When calling
fromEquirectangular
(or_fromTexture
in general) without a render target (defaultnull
) for a second time with a texture with a different height than the texture for the first call, but the same width, the_pingPongRenderTarget
is not replaced. After which the lighting from setting theScene.environment
to the render target texture fails, in two different ways, depending on the order (larger or smaller height first/second).