WebGLClipping: Project global clipping planes per camera #25272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Jan 11, 2023
0b5vr
added a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Jan 30, 2023
- Remove the third argument of `init` (`camera`) - Add `setGlobalState(plane, camera): void` See: mrdoob/three.js#25272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #25267
Description
The global clipping planes were projected during the
clipping.initinvocation using the (main) camera. This would result in incorrect clipping planes when using anArrayCamera. This PR moves the projecting out of theinitmethod and into a dedicatedsetGlobalStatemethod (analogous tosetState). This is then called inrenderSceneensuring it's called exactly once per (sub) camera. Note that for shadow map rendering the global clipping planes aren't used, so it's no problem for them to not be computed at that point.This contribution is funded by Fern Solutions