Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes: Fix texture reference #25259

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Nodes: Fix texture reference #25259

merged 1 commit into from
Jan 9, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jan 7, 2023

Related issue: Closes #25253

This contribution is funded by Google

@sunag sunag added this to the r149 milestone Jan 7, 2023
@LeviPesin
Copy link
Contributor

LeviPesin commented Jan 8, 2023 •
edited
Loading

It seems that this PR fixes https://jsfiddle.net/3jb9eka0/ but does not fix https://jsfiddle.net/dta0qng6/... But maybe this is another issue, unrelated to #25253.

@sunag
Copy link
Collaborator Author

sunag commented Jan 9, 2023

but does not fix https://jsfiddle.net/dta0qng6/... But maybe this is another issue

Yes, it will need another review.

@sunag sunag merged commit 00d426a into mrdoob:dev Jan 9, 2023
@sunag sunag deleted the dev-texture-reference branch January 9, 2023 12:02
@0b5vr 0b5vr mentioned this pull request Jan 30, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r149
Development

Successfully merging this pull request may close these issues.

Texture does not apply to material if it has been already rendered in WebGPU
2 participants
@sunag @LeviPesin