Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWOLoader: Remove workaround for Safari 9. #25245

Merged
merged 3 commits into from
Jan 7, 2023
Merged

LWOLoader: Remove workaround for Safari 9. #25245

merged 3 commits into from
Jan 7, 2023

Conversation

aardgoose
Copy link
Contributor

Description

Remove workaround for missing TypedArray.prototype.indexOf() method in Safari 9.

Supported in all browsers post Safari 9.1
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/indexOf

Note: the help function isEven() previously used here results in 0 if even and 1 if odd which is counterintuitive.

@mrdoob mrdoob added this to the r149 milestone Jan 7, 2023
@mrdoob mrdoob merged commit 593d9d1 into mrdoob:dev Jan 7, 2023
@aardgoose aardgoose deleted the lwo branch June 7, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants