Loaders: Remove use of LoaderUtils.decodeText().
#25236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
reviewed
Jan 5, 2023
mark textDecoder as private
Mugen87
changed the title
LoaderUtils.decodeText().
CodyJasonBennett
added a commit
to CodyJasonBennett/three-stdlib
that referenced
this pull request
May 21, 2023
CodyJasonBennett
added a commit
to pmndrs/three-stdlib
that referenced
this pull request
May 21, 2023
Mercury21th000
pushed a commit
to Mercury21th000/three-stdlib
that referenced
this pull request
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TextDecoder() is now supported by modern browsers and supported versions of node.
This removes all use of LoaderUtils.decodeText() from examples, which can then be deprecated. In some loaders this also reduces the number of new TextDecoder instances created.