-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Set ColorManagement.legacyMode = false #25222
Conversation
Note that while setting An alternative would be to provide a color picker with proper support for other color spaces. I'm open to this, but don't know of one to recommend. If the HTML picker evolves to handle color spaces provided by CSS Color Module Level 4, that would also help a lot. |
Is the editor updated in lockstep with three releases? Noting #24975 (comment), this will need to be updated alongside #24940. |
Generally, yes. Perhaps some exceptions for a patch. I'd like to see both this and #24940 land, but I think they can land in separate releases without harm. |
Published apps also need an enhancement so the colors look exactly like in the editor. You just have to add https://github.com/mrdoob/three.js/blob/dev/editor/js/libs/app/index.html |
Done, thanks! |
The
<input type="color">
HTML element provides an sRGB color picker1, and the preview swatches shown in the picker reflect that, but the Editor does not. I think it would be best to account for the color space when working in the Editor. This allows, for example, setting#1A7FEB
anywhere in the Editor and seeing the color consistently in the HTML picker, MeshBasicMaterial color, Fog color, and so on.Related:
1 By default in Safari and Firefox, and with no other options in Chrome. The option to reach Linear-sRGB ("Rec. ITU-R BT.709-5") in Safari and Firefox is pretty hard to find, and I doubt we can expect users to do so. That option does not affect the value returned to the page, which appears to be sRGB in any case.