WebGLShadowmap: Handle TwoPassDoubleSide case

[WestLangley]

No description provided.

[WestLangley]

@gkjohnson @Mugen87

In light of this PR, does this code block need to be changed?

three.js/src/renderers/webgl/WebGLShadowMap.js

Lines 280 to 288 in f296f21

	if ( type === VSMShadowMap ) {
	result.side = ( material.shadowSide !== null ) ? material.shadowSide : material.side;
	} else {
	result.side = ( material.shadowSide !== null ) ? material.shadowSide : shadowSide[ material.side ];
	}

[gkjohnson]

With a quick look - it seems like it should be okay? The renderer falls back to using DoubleSided renderering with non transparent materials. But maybe it's worth being explicit?

three.js/src/renderers/WebGLRenderer.js

Lines 831 to 847 in 87223b8

	if ( material.transparent === true && material.side === TwoPassDoubleSide ) {
	material.side = BackSide;
	material.needsUpdate = true;
	getProgram( material, scene, object );
	material.side = FrontSide;
	material.needsUpdate = true;
	getProgram( material, scene, object );
	material.side = TwoPassDoubleSide;
	} else {
	getProgram( material, scene, object );
	}

[LeviPesin]

Shouldn't we do { [ FrontSide ]: BackSide, [ BackSide ]: FrontSide, ... } here?

[WestLangley]

Rephrasing my question... Is VSM handled correctly given material.side can now be TwoPassDoubleSide? (Should it map to DoubleSide?)

three.js/src/renderers/webgl/WebGLShadowMap.js

Lines 280 to 288 in f296f21

	if ( type === VSMShadowMap ) {
	result.side = ( material.shadowSide !== null ) ? material.shadowSide : material.side;
	} else {
	result.side = ( material.shadowSide !== null ) ? material.shadowSide : shadowSide[ material.side ];
	}

FYI, see related comment.

[gkjohnson]

Rephrasing my question... Is VSM handled correctly given material.side can now be TwoPassDoubleSide? (Should it map to DoubleSide?)

What I'm saying is that the render behavior for shadows with DoubleSide and TwoPassDoubleSide should be the same since the materials are not transparent.

[WestLangley]

Thanks, @gkjohnson for your reply.

I still am not a fan this design, but the code needs to be fixed, so merging.