Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLBufferAttribute: Add name property. #25219

Merged
merged 1 commit into from
Jan 2, 2023
Merged

GLBufferAttribute: Add name property. #25219

merged 1 commit into from
Jan 2, 2023

Conversation

mikkom
Copy link
Contributor

@mikkom mikkom commented Jan 2, 2023

Description

This change simply initializes a name field in GLBufferAttribute constructor to an empty string. This matches what is done in BufferAttribute and InterleavedBufferAttribute. The reason for this small change is to have a common name field for all buffer attributes in the corresponding TS types (see three-types/three-ts-types#295 (comment)).

@Mugen87 Mugen87 added this to the r149 milestone Jan 2, 2023
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good for consistency to make this addition.

@Mugen87 Mugen87 changed the title Add name field to GLBufferAttribute GLBufferAttribute: Add name property. Jan 2, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 2, 2023

BTW: Please add the new property to the documentation: https://threejs.org/docs/index.html#api/en/core/GLBufferAttribute

@mikkom
Copy link
Contributor Author

mikkom commented Jan 2, 2023

BTW: Please add the new property to the documentation: https://threejs.org/docs/index.html#api/en/core/GLBufferAttribute

Good point. I have now updated the English documentation to include the name field.

@Mugen87 Mugen87 merged commit 92ad11d into mrdoob:dev Jan 2, 2023
@Mugen87 Mugen87 mentioned this pull request Jan 2, 2023
@0b5vr 0b5vr mentioned this pull request Jan 11, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants