PLYLoader: Improve parsing performance. #25210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geometry properties as required and avoid converting entire binary files to ascii for header parsing.
Mugen87
changed the title
Mugen87
reviewed
Jan 2, 2023
Mugen87
approved these changes
Jan 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The loader redundantly performs property mapping per vertex and face and converts entire binary files to ascii for header parsing.
Only map element properties to output geometry properties as required instead of per vertex or face.
Avoid converting entire binary files to ascii for header parsing - ( 5s before, sub 1ms for lucy.ply after changes)
Approximate performance changes:
lucy100K.ply
Before: 100ms
After: 50ms
lucy.ply (original 500MB Stanford copy)
Before: 27s
After: 7s