SVGLoader: Fix parsing of 'points' attribute #25206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SVGLoader()
parses the values ofpoints
attribute of<polyline>
/<polygon>
wrongly.For example, it parses
1e2,50
to a pair of2
and50
, not100
and50
; the problem is that the value of the attribute is defined to be a list of<number>+
1, which allows numerals in the exponential notation2, butSVGLoader()
's regex does not.Demo: https://stackblitz.com/edit/js-ulgby6?devToolsHeight=33&file=index.js
This is caused by the following regex in
SVGLoader.js
for parsing<polyline>
/<polygon>
. This PR fixes the regex accordingly.three.js/examples/jsm/loaders/SVGLoader.js
Line 869 in 4fa0146
three.js/examples/jsm/loaders/SVGLoader.js
Line 904 in 4fa0146
Footnotes
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/points ↩
https://developer.mozilla.org/en-US/docs/Web/SVG/Content_type#number ↩