ViewHelper: Remove dependency to EditorControls
.
#25202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
ViewHelper
has a dependency toEditorControls
right now by relying on the control'scenter
property. That makes it a bit inconvenient to us the helper with other controls likeOrbitControls
. You essentially have to do this:The PR removes the dependency and introduces a new
center
property instead.ViewHelper.center
can be directly modified by app level code or the center/target property of a control class can be assigned to it (like ineditor/js/Viewport.js
).