Remove JS syntax > ECMA 2018 #25172
Merged
Remove JS syntax > ECMA 2018 #25172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Dec 22, 2022
|
Ohh!! No problems, as soon as you merger this PR I will update this #25170 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #25168
Description
This PR removes all JS syntax > ECMA 2018 from the code base.
@sunag I see optional chaining was frequently used in node material classes. For now let's stick to the ternary operator or ordinary
ifstatements. I've also removed the usage of static fields. These are now just added to the class namespace like in the core. Having static methods is fine, btw.