Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Support to AmbientLight, DirectionalLight, SpotLight #25150

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 15, 2022

@sunag sunag added this to the r148 milestone Dec 15, 2022
@sunag sunag marked this pull request as ready for review December 15, 2022 18:49
@sunag
Copy link
Collaborator Author

sunag commented Dec 16, 2022

A positive point of the current architecture... We added new light types, and we didn't need to add any modifications to WebGPURenderer. Users can create their own light type without having to modify the core.

@sunag sunag merged commit b07dab2 into mrdoob:dev Dec 16, 2022
@sunag sunag deleted the dev-lights-nodes branch December 16, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant