WebGLBackground: Don't tone map sRGB backgrounds. #25134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What advice should we give users about post-processing, where tone mapping must still affect the background? It's necessary to use a background that is not constrained to the closed domain [0,1] then? |
|
I think I would be in favor of this PR's changes, in any case. It's a better default, unless/until we want to expose a |
|
I would implement it like this, however: boxMesh.material.toneMapped = ( background.encoding === sRGBEncoding ) ? false: true; |
|
Your wish is my command, @WestLangley 😄 |
Mugen87
approved these changes
Dec 14, 2022
Mugen87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: google/model-viewer#3953 (reply in thread)
Description
An eagle-eyed user correctly identified that we were applying tone mapping to the background image (see screenshots in the link above). I've fixed this by disabling tone mapping for the background material when the texture's encoding is
sRGBEncoding. My rationale for this is that an sRGB texture is expected to be displayed 1:1 (as is already true for background colors), while tone mapping only makes sense for colors that go past 1, for whichLinearEncodingis always used.Verified locally with model-viewer and the user-supplied background.