Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example webgl_materials_lightmap: Port ShaderMaterial to NodeMaterial #25123

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 12, 2022

Description

Statistically we can see a simplification using NodeMaterial instead of ShaderMaterial [ 23 additions and 58 deletions. ]. I believe we can migrate other examples, as soon as the WebGPURenderer is ready the example will work for both WebGL and WebGPU.

NOTE: Is possible to realize a little difference between this and the old example in sky material, it's because the old example to doesn't apply LinearTosRGB in output of sky material.

This contribution is funded by Google

@sunag sunag marked this pull request as ready for review December 12, 2022 13:13
@Mugen87 Mugen87 added this to the r148 milestone Dec 14, 2022
@Mugen87 Mugen87 merged commit 3d27aad into mrdoob:dev Dec 14, 2022
@sunag sunag deleted the dev-to-nodes branch December 14, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants