Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: Cleanup all( bvecN( ... ) ). #25119

Merged
merged 7 commits into from
Dec 14, 2022
Merged

Conversation

LeviPesin
Copy link
Contributor

Related issue: -

Description

Remove all( bvecN( ... ) ) introduced almost 11 years ago as a workaround for a compiler bug.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 12, 2022

Sidenote: It seems ab0ce36 did not introduce the all() and bvecN() syntax 🤔 .

@Mugen87 Mugen87 changed the title Cleanup all( bvecN( ... ) ) Shaders: Cleanup all( bvecN( ... ) ). Dec 12, 2022
@LeviPesin
Copy link
Contributor Author

LeviPesin commented Dec 12, 2022

It was the first to introduce these comments, the syntax, it seems, was introduced by 3dea259.

@Mugen87 Mugen87 added this to the r148 milestone Dec 12, 2022
@Mugen87 Mugen87 merged commit 5e72560 into mrdoob:dev Dec 14, 2022
@LeviPesin LeviPesin deleted the cleanup-all-bvecn branch January 5, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants