Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSMShader: Fix shadows with spotlights. #25116

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Conversation

titansoftime
Copy link
Contributor

vSpotShadowCoord seems to have been replaced with vSpotLightCoord in r147. CSMShader.js needed to be updated.

Spotlights under CSM fail without this update.

vSpotShadowCoord seems to have been replaced with vSpotLightCoord in r147. CSMShader.js needed to be updated.
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming vSpotShadowCoord to vSpotLightCoord was actually done in r144 (#21944).

@Mugen87 Mugen87 added this to the r148 milestone Dec 12, 2022
@Mugen87 Mugen87 merged commit 2cd8541 into mrdoob:dev Dec 12, 2022
@Mugen87 Mugen87 changed the title Update CSMShader.js for r147 CSMShader: Fix shadows with spotlights. Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants