Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Euler: Updated static class properties to ALL_CAPS #25104

Merged
merged 5 commits into from
Dec 23, 2022
Merged

Euler: Updated static class properties to ALL_CAPS #25104

merged 5 commits into from
Dec 23, 2022

Conversation

WestLangley
Copy link
Collaborator

As proposed in #25015 (comment).

@WestLangley WestLangley added this to the r148 milestone Dec 10, 2022
@WestLangley
Copy link
Collaborator Author

If this looks good, I'll do the same for Object3D.

LeviPesin
LeviPesin reviewed Dec 10, 2022
View reviewed changes
src/math/Euler.js Outdated Show resolved Hide resolved
@LeviPesin LeviPesin mentioned this pull request Dec 10, 2022
Closed
@WestLangley WestLangley mentioned this pull request Dec 15, 2022
Merged
@mrdoob mrdoob modified the milestones: r148, r149 Dec 22, 2022
@WestLangley
Copy link
Collaborator Author

@Mugen87 said:

I suggest to just remove the old syntax without a fallback. A note [in the] migration guide is for this case sufficient.

OK, done!

@Mugen87 Mugen87 merged commit 4d6d52a into mrdoob:dev Dec 23, 2022
@WestLangley WestLangley deleted the dev-euler_static branch December 23, 2022 17:44
@0b5vr 0b5vr mentioned this pull request Jan 12, 2023
Closed
14 tasks
0b5vr added a commit to 0b5vr/three-ts-types that referenced this pull request Jan 24, 2023
@0b5vr
fix (Euler): Update static class properties to ALL_CAPS
1c79021 
See: mrdoob/three.js#25104
@0b5vr 0b5vr mentioned this pull request Jan 24, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeviPesin LeviPesin LeviPesin left review comments

@marcofugaro marcofugaro marcofugaro left review comments

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r149
Development

Successfully merging this pull request may close these issues.
5 participants
@WestLangley @marcofugaro @Mugen87 @LeviPesin @mrdoob