Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGLoader: Fix hole identifier. #25065

Merged
merged 7 commits into from
Dec 5, 2022
Merged

SVGLoader: Fix hole identifier. #25065

merged 7 commits into from
Dec 5, 2022

Conversation

Ttommeke
Copy link
Contributor

@Ttommeke Ttommeke commented Dec 2, 2022

Fixed #24780.

Description

SVG path filter on holes with 2 or less points messed up the hole identifier.

@Ttommeke
Copy link
Contributor Author

Ttommeke commented Dec 2, 2022

Fix for: #24780

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 2, 2022

It seems your branch is still way behind dev which produces merge conflicts. Probably best if you rebase.

@gregsadetsky
Copy link
Contributor

gregsadetsky commented Dec 5, 2022

Hey @Ttommeke -- congrats on the fix!

I saw that you included the svg file from my original issue into the webgl_loader_svg.html examples -- so happy to see that it works now!

I also re-ran my diy fuzzer, and all of the paths worked. 0 errors.

Cheers, super happy about this. Congrats again and thanks for your work!

@Mugen87 Mugen87 changed the title Is hole fix SVGLoader: Fix hole identifier. Dec 5, 2022
@Mugen87 Mugen87 added this to the r148 milestone Dec 5, 2022
@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 5, 2022

It seems the original issue of the OP is fixed now 👍 .

However, when loading singlePointTest3.svg, the output looks different compared to opening the SVG directly in the browser. Is this a known issue?

browser SVGLoader
image image

@Ttommeke
Copy link
Contributor Author

Ttommeke commented Dec 5, 2022

Yes. The SVG specifications doesn't support intersecting paths. It thus leaves it up to the implementation how to handle the rendering of these paths. The result you see in the browser is the effect/result of their standard algorithm at work. Same for us. Only a different outcome.

@Mugen87 Mugen87 merged commit 580ca90 into mrdoob:dev Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVGLoader: Exception in isHoleTo when loading an SVG file
3 participants