-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVGLoader: Fix hole identifier. #25065
Conversation
Fix for: #24780 |
It seems your branch is still way behind |
Hey @Ttommeke -- congrats on the fix! I saw that you included the svg file from my original issue into the I also re-ran my diy fuzzer, and all of the paths worked. 0 errors. Cheers, super happy about this. Congrats again and thanks for your work! |
Yes. The SVG specifications doesn't support intersecting paths. It thus leaves it up to the implementation how to handle the rendering of these paths. The result you see in the browser is the effect/result of their standard algorithm at work. Same for us. Only a different outcome. |
Fixed #24780.
Description
SVG path filter on holes with 2 or less points messed up the hole identifier.