Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Fix usage of USDZExporter. #25055

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Editor: Fix usage of USDZExporter. #25055

merged 1 commit into from
Dec 1, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 1, 2022

Related issue: -

Description

The editor applies an invalid options parameter to the exporter which breaks the current usage.

@Mugen87 Mugen87 added this to the r148 milestone Dec 1, 2022
@Mugen87 Mugen87 merged commit 59020b2 into mrdoob:dev Dec 1, 2022
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 1, 2022 •
edited
Loading

@mrdoob I believe we should cherry-pick this hotfix to gh-pages 😇 .

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 1, 2022 •
edited
Loading

Um, the implementation of the options parameter is not equal for all exporters. Some exporters like USDZExporter or DRACOExporter require the definition of all option properties if the parameter is defined. Maybe we should do it similar to GLTFLoader or ColladaLoader and use Object.assign() instead?

@mrdoob
Copy link
Owner

mrdoob commented Dec 2, 2022

@mrdoob I believe we should cherry-pick this hotfix to gh-pages 😇 .

Done!

@mrdoob
Copy link
Owner

mrdoob commented Dec 2, 2022

Hmm... How/when did this break? 🤔

mrdoob pushed a commit that referenced this pull request Dec 2, 2022
@Mugen87 @mrdoob
Editor: Fix usage of USDZExporter. (#25055)
922ece6
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 2, 2022 •
edited
Loading

When anchoring support was added in r147, an options parameter in USDZExporter.parse() was introduced. For some reasons (probably a copy/paste error) the editor already provided a parameter but with wrong properties.

Related changes: #22854, #24865

@pnacht pnacht mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r148
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob