Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Remove dependency checks from postprocessing. #25051

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 1, 2022

Related issue: #25043

Description

The modules in postprocessing have many checks to inform example/js users if they have missed to include a dependency.

After removing example/js, these checks are not necessary anymore since ES6 modules automatically load their dependencies.

I've also removed the embedded Pass and FullScreenQuad definitions in EffectComposer. They were only added for the examples/js version of EffectComposer.

@Mugen87 Mugen87 added this to the r148 milestone Dec 1, 2022
@Mugen87 Mugen87 merged commit 047f163 into mrdoob:dev Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant