Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: New features and revisions #25041

Merged
merged 7 commits into from
Dec 1, 2022
Merged

Nodes: New features and revisions #25041

merged 7 commits into from
Dec 1, 2022

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 30, 2022

Description

CacheNode

The new caching system will be the basis for radiance and irradiance flows which should use different caches, it also adds partial support for environment using Texture2D in WebGPU but needs PMREM to work properly. The cache will also be used in upcoming SwitchNode and LoopNode features.

API:

const isolatedNode = cache( someNode ); // creates an independent cache

StackNode

API:

const computeShaderNode = new ShaderNode( ( inputs, stack ) => {

	// ...

	const storageElementNode = element( someStorageNode, instanceIndex );

	// StackNode API -> stack.assign( targetNode, sourceNode )

	stack.assign( storageElementNode, valueNode );

} );

This contribution is funded by Google

@sunag sunag added this to the r148 milestone Nov 30, 2022
@sunag sunag changed the title Nodes: New cache system and revisions (WIP) Nodes: New features and revisions (WIP) Dec 1, 2022
@sunag
Copy link
Collaborator Author

sunag commented Dec 1, 2022

@mrdoob @LeviPesin stack.assign( a, b ) instead of assign( a, b ).build( builder ). More simple and stable.

@sunag sunag changed the title Nodes: New features and revisions (WIP) Nodes: New features and revisions Dec 1, 2022
@sunag sunag marked this pull request as ready for review December 1, 2022 04:26
@sunag sunag merged commit f402578 into mrdoob:dev Dec 1, 2022
@sunag sunag deleted the dev-nodes-cache branch December 1, 2022 06:19
@0b5vr 0b5vr mentioned this pull request Dec 23, 2022
10 tasks
@Methuselah96 Methuselah96 mentioned this pull request Jan 18, 2024
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants