Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDZLoader: Fix loading files exported with USDZExporter #25023

Merged
merged 2 commits into from
Nov 26, 2022

Conversation

hybridherbst
Copy link
Contributor

@hybridherbst hybridherbst commented Nov 26, 2022

Description

Since #22854 added a "Scope" wrapper object for the exported USDZ, and the USDZLoader so far was only able to load flat hierarchies, USDZLoader couldn't load the files exported with USDZExporter anymore.

This PR fixes that by introducing very basic hierarchy support on import, enough to support these files again.

Note: we (Needle) already have USDZExporter hierarchy support in our three.js fork, hope I get to make a PR soon.

This contribution is funded by Needle

@Mugen87 Mugen87 added this to the r147 milestone Nov 26, 2022
@Mugen87 Mugen87 merged commit a1a0eaf into mrdoob:dev Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants