Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Make navigator access more robust. #24989

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Conversation

Hoodgail
Copy link
Contributor

Description
This pull request will only request navigator if it is defined, as GLTFLoader attempts to retrieve navigator, but this will throw an error for headless gltf support.

Hoodgail and others added 2 commits November 19, 2022 14:12
This pull request will only request navigator if it is defined, as GLTFLoader attempts to retrieve navigator, but this will throw an error for headless gltf support.
@Mugen87 Mugen87 changed the title GLTFLoader: headless GLTFLoader: Make navigator access more robust. Nov 20, 2022
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we check for navigator at other places in the code base, it's appropriate to make this change.

@mrdoob mrdoob added this to the r147 milestone Nov 20, 2022
@mrdoob mrdoob merged commit 830370f into mrdoob:dev Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants