Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix3: Added 2D transform methods #24985

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Matrix3: Added 2D transform methods #24985

merged 2 commits into from
Nov 20, 2022

Conversation

WestLangley
Copy link
Collaborator

As suggested in #24733 (comment).

This PR adds 2D transform methods to Matrix3. These methods parallel the similarly-named Matrix4 methods:

// for 2D Transforms

makeTranslation( x, y )

makeRotation( theta )

makeScale( x, y )

@WestLangley WestLangley added this to the r147 milestone Nov 19, 2022
@WestLangley WestLangley mentioned this pull request Nov 19, 2022
Merged
@mrdoob mrdoob merged commit bd4667b into mrdoob:dev Nov 20, 2022
@WestLangley WestLangley deleted the dev-matrix3_2d_transforms branch November 20, 2022 22:48
@Mugen87 Mugen87 mentioned this pull request Nov 21, 2022
Open
@0b5vr 0b5vr mentioned this pull request Dec 7, 2022
Closed
12 tasks
0b5vr added a commit to three-types/three-ts-types that referenced this pull request Dec 19, 2022
@0b5vr
feat: Add makeTranslation, makeRotation, makeScale to Matrix3
7f3ea9e 
mrdoob/three.js#24985
@WestLangley WestLangley mentioned this pull request May 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r147
Development

Successfully merging this pull request may close these issues.
3 participants
@WestLangley @Mugen87 @mrdoob