Move ShaderNode internals to a Node class #24961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunag Feel free to merge this if it looks good to you 👍 |
|
@LeviPesin this broke |
|
Should be fixed now. |
LeviPesin
commented
Nov 17, 2022
|
@LeviPesin I added some changes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
Currently something like
material.colorNode = new ShaderNode( ... )does not work in WebGL nodes (tested that), becausenew ShaderNode( ... )does not have anisNodeproperty (and also does not have a cache key implementation).This PR fixes that and implements the @sunag's suggestion in the comment
// @TODO: Move this to Node extended class.