Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLState: assign boolean to currentPremultipledAlpha #24955

Merged
merged 1 commit into from
Nov 15, 2022
Merged

WebGLState: assign boolean to currentPremultipledAlpha #24955

merged 1 commit into from
Nov 15, 2022

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Nov 14, 2022

should assign false, instead of null, to currentPremultipledAlpha bc its strictly inequality checked against a bool

three.js/src/renderers/webgl/WebGLState.js

Lines 613 to 615 in ac30ce0

if ( blending !== CustomBlending ) {
if ( blending !== currentBlending || premultipliedAlpha !== currentPremultipledAlpha ) {

@Mugen87 Mugen87 added this to the r147 milestone Nov 14, 2022
@mrdoob mrdoob merged commit c24bba4 into mrdoob:dev Nov 15, 2022
@ycw ycw deleted the patch-2 branch November 15, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r147
Development

Successfully merging this pull request may close these issues.
3 participants
@ycw @Mugen87 @mrdoob