Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Support accessors with no bufferView. #24904

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 3, 2022

Fixed #24838.

Description

This PR adds support for accessors with no bufferView by creating an "empty" BufferAttribute. Meaning a buffer initializes with zeros.

@Mugen87 Mugen87 added this to the r147 milestone Nov 3, 2022
@Mugen87 Mugen87 requested a review from donmccurdy November 3, 2022 10:04
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

It might also be good to pass in accessorDef.normalized, but doesn't particularly matter if it's all zeros I guess.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 3, 2022

Updated the PR. It's indeed better to honor the normalized flag, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLTFLoader: Accessor with no bufferView create an error
2 participants