-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USDZExporter: Add camera support. #24854
Conversation
three.js/examples/misc_exporter_gltf.html Lines 155 to 159 in a10999a
|
Ah cool, thanks for the context and help on my first ThreeJS PR! @Mugen87 |
lint minor fix lint extension error cherry-pick changes done to USDZExporter in the meantime USDZExporter: Add camera support. (mrdoob#24854) USDZExporter: Anchoring support (mrdoob#22854) clean up camera exporting, set default plane to horizontal USDZExporter: add desktop download button to sample fix: don't export opacity if model is opaque, leads to incorrect rendering effects feat: add uv2 support, make sure TextureTransform is only written when needed, use uv2 for occlusion simplify st / st2 access USDZExporter: fix exception when trying to process render targets fix: pass writer into onAfterHierarchy callback, move onAfterHierarchy callback after scene hierarchy write pass options and extensions correctly
lint minor fix lint extension error cherry-pick changes done to USDZExporter in the meantime USDZExporter: Add camera support. (mrdoob#24854) USDZExporter: Anchoring support (mrdoob#22854) clean up camera exporting, set default plane to horizontal USDZExporter: add desktop download button to sample fix: don't export opacity if model is opaque, leads to incorrect rendering effects feat: add uv2 support, make sure TextureTransform is only written when needed, use uv2 for occlusion simplify st / st2 access USDZExporter: fix exception when trying to process render targets fix: pass writer into onAfterHierarchy callback, move onAfterHierarchy callback after scene hierarchy write pass options and extensions correctly Only print usdz in debug mode # Conflicts: # examples/jsm/exporters/USDZExporter.js
lint minor fix lint extension error cherry-pick changes done to USDZExporter in the meantime USDZExporter: Add camera support. (mrdoob#24854) USDZExporter: Anchoring support (mrdoob#22854) clean up camera exporting, set default plane to horizontal USDZExporter: add desktop download button to sample fix: don't export opacity if model is opaque, leads to incorrect rendering effects feat: add uv2 support, make sure TextureTransform is only written when needed, use uv2 for occlusion simplify st / st2 access USDZExporter: fix exception when trying to process render targets fix: pass writer into onAfterHierarchy callback, move onAfterHierarchy callback after scene hierarchy write pass options and extensions correctly Only print usdz in debug mode # Conflicts: # examples/jsm/exporters/USDZExporter.js
lint minor fix lint extension error cherry-pick changes done to USDZExporter in the meantime USDZExporter: Add camera support. (mrdoob#24854) USDZExporter: Anchoring support (mrdoob#22854) clean up camera exporting, set default plane to horizontal USDZExporter: add desktop download button to sample fix: don't export opacity if model is opaque, leads to incorrect rendering effects feat: add uv2 support, make sure TextureTransform is only written when needed, use uv2 for occlusion simplify st / st2 access USDZExporter: fix exception when trying to process render targets fix: pass writer into onAfterHierarchy callback, move onAfterHierarchy callback after scene hierarchy write pass options and extensions correctly Only print usdz in debug mode # Conflicts: # examples/jsm/exporters/USDZExporter.js
Description
Adding support for perspective and orthographic cameras added to the scene to be exported.
Discussion
This requires the camera to be explicitly added to the scene to be picked up, useful when there are multiple cameras, but potentially confusing for basic examples, as adding a camera to the scene is not common Three.js practice. Happy to discuss if there is a better way to allow this.