Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGLoader: support arbitrary arcs arbitrary transforms #24778

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

nkrkv
Copy link
Contributor

@nkrkv nkrkv commented Oct 11, 2022

Related issue: #21330

This PR completes the story of correct ellipses and arc loading started in #24750. Now correctly supports flip transformations and arbitrary arc-skew. In summary, SVGLoader is now capable to load correctly an arbitrary ellipse or arc with an arbitrary transformation.

Test fixture (Inkscape)

image

Before

image

After

image

@nkrkv nkrkv changed the title Svg ellipse transform 2 SVGLoader: support arbitrary arcs arbitrary transforms Oct 11, 2022
@Mugen87 Mugen87 added this to the r146 milestone Oct 11, 2022
@Mugen87 Mugen87 requested a review from yomboprime October 12, 2022 14:01
Copy link
Collaborator

@yomboprime yomboprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't verify the maths of transfEllipseGeneric() or eigenDecomposition() functions, but the rest seems right to me.

@mrdoob mrdoob merged commit d75f4d1 into mrdoob:dev Oct 13, 2022
@mrdoob
Copy link
Owner

mrdoob commented Oct 13, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants