Earcut: Upgrade to version 2.2.4. #24760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to upgrade the earcut implementation, it should not be necessary to update E2E screenshots. That only indicates something has changed or even broken. |
Thanks for your reply. I have also found this problem and am now testing it by myself. |
yanranxiaoxi
changed the title
yanranxiaoxi
changed the title
Mugen87
reviewed
Oct 11, 2022
yanranxiaoxi
commented
Oct 13, 2022
Clean up.
Mugen87
changed the title
Mugen87
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the
Earcutalgorithm to the latest version (2.2.4) to fix infinite loop.