-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scene: Add background blur with PMREM. #24752
Conversation
src/renderers/shaders/ShaderChunk/envmap_common_pars_fragment.glsl.js
Outdated
Show resolved
Hide resolved
I support your PR in principle, but not how it has been shoehorned into the existing shaders. I have been trying to clean up the shaders, and this is not helping. I am hopeful that if this is merged, we can work together on some shader refactoring. |
Definitely. IMO when adding new features, there is no need to make the implementation perfect right from the beginning. As long as the basic approach is right, we can use refactoring to fine-tune things at a later point. |
Let's merge so we can easier move on with the suggested refactoring. |
Updated builds: 4e93f9b |
About the refactoring: I guess the goal is that the background material does not depend on |
I think that would be OK. I am assuming it would be used exclusively by
Nit: I would prefer to say it this way: "so it also handles texture cubes and equirectangular textures". |
Related issue: #23712
Description
This is the alternative implementation of #23712 but via PMREMs.