Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderTarget: Use default parameters for dimensions. #24747

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 5, 2022

Related issue: #24744 (comment)

Description

This PR introduces default parameters for the dimensions of render targets.

@mrdoob mrdoob added this to the r146 milestone Oct 7, 2022
@mrdoob
Copy link
Owner

mrdoob commented Oct 7, 2022

Looks good to me!

@mrdoob mrdoob merged commit e732f0c into mrdoob:dev Oct 7, 2022
@mrdoob
Copy link
Owner

mrdoob commented Oct 7, 2022

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Oct 7, 2022

I guess we don't need the // will be resized later comments anymore? 😅

@joshuaellis joshuaellis mentioned this pull request Oct 31, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants