Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Move remaining classes to Pointer Events. #24693

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Sep 25, 2022

Related issue: #20170, #20168

Description

This PR moves FlyControls and FirstPersonControls from mouse to pointer events.

The original PRs were not merged since we were unsure about renaming properties and methods in the public scope. However, the affected entities are no part the actual public API so it is safe to rename them.

@Mugen87 Mugen87 added this to the r145 milestone Sep 25, 2022
@Mugen87 Mugen87 changed the title Controls: Remove remaining classes to Pointer Events. Controls: Move remaining classes to Pointer Events. Sep 26, 2022
@mrdoob mrdoob merged commit 105685d into mrdoob:dev Sep 27, 2022
@mrdoob
Copy link
Owner

mrdoob commented Sep 27, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Sep 27, 2022
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants