Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dispose() method to helpers #24655

Merged
merged 2 commits into from
Sep 18, 2022

Conversation

WestLangley
Copy link
Collaborator

As suggested in #24646 (comment).

@WestLangley WestLangley marked this pull request as ready for review September 18, 2022 02:22
@WestLangley WestLangley added this to the r145 milestone Sep 18, 2022
@WestLangley WestLangley changed the title Add dispose() method to helpers Added dispose() method to helpers Sep 18, 2022
@WestLangley
Copy link
Collaborator Author

This PR is good-to-go. Remaining helpers will be updated separately.

@WestLangley WestLangley merged commit 01185b1 into mrdoob:dev Sep 18, 2022
@WestLangley WestLangley deleted the dev-dispose_methods branch September 18, 2022 18:54
@joshuaellis joshuaellis mentioned this pull request Sep 27, 2022
17 tasks
@VeinSyct
Copy link

VeinSyct commented Oct 1, 2022

wow the r145 solves the memory allocation error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants