VRMLLoader: Process Anchor node as grouping node. #24645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #24644.
Description
VRMLLoadernow processes nodes of typeAnchoras ordinary grouping nodes.urlfields and the respective fetch of resources is not supported.@XMZovo This change ensures the yellow spheres are rendered. The error of
computeBoundingSphere()is caused by invalid line definitions of your asset. It seems Geant4 export lines with just one vertex which does not seem to make sense. It's probably best if you ask for a fix for their exporter. In the meanwhile, traverse through the loaded VRML asset and remove the problematic line segments from your scene.