WebGLUniforms: Cache texture unit values when setting texture array uniforms. #24637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Sep 13, 2022
Mugen87
changed the title
|
FYI: Not all uniform arrays are cached because of #16355. |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed a bunch of redundant uniform1iv calls in a scene that used cascaded shadow maps (which use a texture array). Turns out, the setValueT*Array calls don't cache off the texture units before setting them; by using the array cache checking stuff like most of the other array uniforms, I was able to shave a bunch of useless uniform1iv calls from my scene and increase perf.
I duplicated this change across the other texture array setters, because I don't think that array ever gets too large and it seems like it probably does more good than harm, but I didn't actually test anything but setValueT1Array.
This contribution is funded by Meta