WebGLState: Fix setting of NeverDepth
.
#24628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While trying different options of
depthFunc
I noticed that setting it toNeverDepth
didn't yield the expected result. Instead of it always failing depth testing and not rendering anything, it rendered "as normal". Looking into the code reveals that there's an if statement, presumably checking if the passeddepthFunc
value is "valid". However, theNeverDepth
constant has the value0
and thus fails this check. As suchNeverDepth
ends up being the same as the defaultLessEqualDepth
.This PR simply removes that if statement and associated else clause, as the else clauses matches the default case in the switch statement. This allows
NeverDepth
to be properly set and, unless I'm missing something obvious, behaves the same otherwise.(Note: the diff makes it look like a lot has changed, but only the if statement and corresponding else clause have been removed, and the indentation level of the switch reduced by one)
This contribution is funded by Fern Solutions