GLTFExporter: Remove truncateDrawRange option.
#24625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
Sep 12, 2022
takahirox
approved these changes
Sep 12, 2022
Mugen87
changed the title
truncateDrawRange option.
|
Thanks! |
|
/fyi @fernandojsg |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* GLTFExporter: Remove truncateDrawRange option. * Update screenshot. * GLTFExporter: Clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
This PR removes the
truncateDrawRangeoption fromGLTFExporter.The feature was originally implemented for A-Painter so only geometry data are exported which were defined via
BufferGeometry.drawRange. However, indexed geometries were never supported.It seems to me that something application specific has been moved into
GLTFExporterwhich I don't think is appropriate.BufferGeometry.drawRangeshould be evaluate by the renderer, not exporters. SinceGLTFExporteris the only exporter that honorsdrawRange, I suggest to removetruncateDrawRangeand state that exporters always process the entire geometry.Closes #15104.