Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved doc on BufferGeometry.dispose() #24616

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

erasta
Copy link
Contributor

@erasta erasta commented Sep 9, 2022

Related issue: #24607

Improved documentation on BufferGeometry.dispose() with a link to the separate page on objects disposing.
Hopefully this will better explain when dispose() is needed and when it can be avoided.
Example of a scenario that wasn't understood from the previous doc: when a geometry is not rendered, it doesn't have to be disposed.

@Mugen87 Mugen87 added this to the r145 milestone Sep 9, 2022
@Mugen87 Mugen87 merged commit f160d03 into mrdoob:dev Sep 9, 2022
@mrdoob
Copy link
Owner

mrdoob commented Sep 9, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Improved doc on BufferGeometry.dispose()

* more compact phrasing
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
* Improved doc on BufferGeometry.dispose()

* more compact phrasing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants