InteractiveGroup: Use getBoundingClientRect() when computing pointer. #24586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt, affecting pointer offset.
Mugen87
approved these changes
Sep 2, 2022
Mugen87
changed the title
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…mrdoob#24586) * Fixed issue with pointer location when placed within child HTML element, affecting pointer offset. * Update InteractiveGroup.js Co-authored-by: OllyJ918 <[email protected]> Co-authored-by: Michael Herzog <[email protected]>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
…mrdoob#24586) * Fixed issue with pointer location when placed within child HTML element, affecting pointer offset. * Update InteractiveGroup.js Co-authored-by: OllyJ918 <[email protected]> Co-authored-by: Michael Herzog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the renderer is placed in a child HTML element that is offset from the top left of the page the pointer locations returned on the click event listener are wrong and offset by the relative location of the renderer element on the page.