Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferGeometryUtils: Fix mergeVertices() with normalized vertex attributes #24577

Merged

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Sep 1, 2022

@danborutori — could you confirm that this fixes the problem you ran into?

@Mugen87 Mugen87 added this to the r145 milestone Sep 6, 2022
@Mugen87 Mugen87 merged commit f70ead9 into mrdoob:dev Sep 9, 2022
@donmccurdy donmccurdy deleted the hotfix/buffergeometry-merge-normalized branch September 9, 2022 10:24
@mrdoob
Copy link
Owner

mrdoob commented Sep 9, 2022

Thanks!

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
…butes (mrdoob#24577)

* BufferGeometryUtils: Fix mergeVertices() with normalized vertex attributes

* Clean up
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
…butes (mrdoob#24577)

* BufferGeometryUtils: Fix mergeVertices() with normalized vertex attributes

* Clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

normalized BufferAttribute and BufferGeometryUtils.mergeVertices get wrong result
3 participants