Added USDZLoader #24568
Merged
Added USDZLoader #24568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the benefit of all the inner functions inside the parse function? My gut tells me they should be outside the class so they don't get redeclared every time the loader is used, but the perf benefits might be minimal. There are a couple of stray console logs in there though which could do with removing. |
|
Seems like USD can have multiple indices per geometry (ie. one for vertices and one for uvs). After converting these arrays to non-indexed we now have working uvs:
|
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* Added USDZLoader. * Added example. * USDZLoader: Flatten indexed data. * Examples: Improved usdz example.
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* Added USDZLoader. * Added example. * USDZLoader: Flatten indexed data. * Examples: Improved usdz example.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #5524 #14219
Description
I was curious to see how big would a basic loader for usdz(usda) be.