ShapePath: Remove noHoles parameter. #24560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
3jsLive
pushed a commit
to 3jsLive/three.js
that referenced
this pull request
Aug 31, 2022
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
ShapePath.toShapes()has some limitations (#16950) andSVGLoader.createShapes()provides a better implementation. I think it makes sense to replace the implementation ofShapePath.toShapes()in future releases with the more robust code fromSVGLoader.createShapes().As a preparation, I suggest to remove the
noHolesparameter fromShapePath.toShapes(). The contour/hole definitions should solely depend on the path definitions like inSVGLoader.createShapes()and not be configurable.It seems the code base did not use the
noHolesparameter anyway and I doubt it has a relevance in user level code.