Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShaderChunk: Fixed crash when using spotlight.map with renderer.shadowMap not enabled #24558

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Aug 30, 2022

Related issues: #21944

Description

This PR fixes a shader compiler crash when using spointlight.map without setting renderer.shadowMap.enabled = true.

Screen Shot 2022-08-29 at 6 46 00 PM

I suspect I broke a specific case though...
I'll continue refactoring and cleaning up the code tomorrow.

/cc @mbredif

@mrdoob mrdoob added this to the r144 milestone Aug 30, 2022
@mrdoob mrdoob merged commit 4f1d2d0 into dev Aug 30, 2022
@mrdoob mrdoob deleted the spotlight_map branch August 30, 2022 01:55
@mbredif
Copy link
Contributor

mbredif commented Aug 30, 2022

thanks for the quick fix, see #24564 for textured spot lights when shadowmapping is off

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants