BufferAttribute: Remove type specific copy methods. #24550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Aug 28, 2022
gkjohnson
approved these changes
Aug 29, 2022
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
* BufferAttribute: Remove type specific copy methods. * BufferAttribute: Clean up. * Update BufferAttribute.js Co-authored-by: mrdoob <[email protected]>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
* BufferAttribute: Remove type specific copy methods. * BufferAttribute: Clean up. * Update BufferAttribute.js Co-authored-by: mrdoob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
This PR removes
copyColorsArray(),copyVector2sArray(),copyVector3sArray()andcopyVector4sArray()fromBufferAttribute. These specific methods were originally introduced as helper/convenience methods for theGeometrytoBufferGeometryconversion. SinceGeometryhas been removed, these methods should be deleted, too.