Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferAttribute: Skip denormalization in set() #24526

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Aug 22, 2022

@donmccurdy donmccurdy added this to the r144 milestone Aug 22, 2022
@donmccurdy donmccurdy requested a review from gkjohnson August 22, 2022 19:53
@donmccurdy
Copy link
Collaborator Author

Note that this change is included in #24512, but I wasn't sure that PR would make it into r144. I do think we need this part of the change in r144.

@donmccurdy donmccurdy changed the title BufferAttribute: Skip normalization in set() BufferAttribute: Skip denormalization in set() Aug 22, 2022
@Mugen87 Mugen87 merged commit b53b760 into mrdoob:dev Aug 22, 2022
@mrdoob
Copy link
Owner

mrdoob commented Aug 22, 2022

Thanks!

@donmccurdy donmccurdy deleted the hotfix/bufferattribute-set branch August 22, 2022 22:55
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 13, 2022
abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
snagy pushed a commit to snagy/three.js-1 that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants