Set stencilBuffer property of WebGLRenderTarget in WebXRManager #24488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cabanier Does this change look good to you? |
LGTM |
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
…ob#24488) Co-authored-by: Noeri Huisman <[email protected]>
snagy
pushed a commit
to snagy/three.js-1
that referenced
this pull request
Sep 21, 2022
…ob#24488) Co-authored-by: Noeri Huisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case a browser doesn't implement the WebXR Layers API, the
WebXRManagerdoesn't set thestencilBufferproperty on the render target. The underlying framebuffer, however, can have a stencil buffer. Functionally the stencil buffer seems to work for as far as I could test, but the render target incorrectly reports that it doesn't have one.This PR simply ensures the
stencilBufferproperty is set accordingly. This is in line with the way it's done in the code path for browsers that do implement the WebXR Layers API (line 325).